Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subpath e2e tests on multizone cluster. #61111

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Fix subpath e2e tests on multizone cluster. #61111

merged 1 commit into from
Mar 13, 2018

Conversation

jsafrane
Copy link
Member

Use dynamically provisioned PV to run GCE PD tests. This will make sure that the pod is scheduled to the right zone and GCE PD can be attached to a node.

Which issue(s) this PR fixes:
Fixes #61101

Release note:

NONE

/sig storage
@msau42 @verult

@jsafrane
Fix subpath e2e tests on multizone cluster.
c44e135 
Use dynamically provisioned PV to run GCE PD tests. This will make sure
that the pod is scheduled to the right zone and GCE PD can be attached
to a node.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2018
@jsafrane jsafrane mentioned this pull request Mar 13, 2018
Closed
msau42
msau42 reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

@jsafrane do you need to pick this to release branches to keep release CI green?

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

and does this need to be in the 1.10 milestone? red CI would make me think it does

@liggitt liggitt added this to the v1.10 milestone Mar 13, 2018
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. status/approved-for-milestone labels Mar 13, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@jsafrane @msau42

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone.

priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help

@liggitt liggitt mentioned this pull request Mar 13, 2018
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61111, 61069). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 32343b7 into kubernetes:master Mar 13, 2018
@jsafrane
Copy link
Member Author

@liggitt, thanks for merging this. Yes, it's for 1.10.

This was referenced Mar 15, 2018
Merged
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Mar 17, 2018
Merge pull request #61236 from verult/automated-cherry-pick-of-#61111…
9192b48 
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61111: Fix subpath e2e tests on multizone cluster.

Cherry pick of #61111 on release-1.9.

#61111: Fix subpath e2e tests on multizone cluster.

``` release-note
Fixes GCE PD volumes in subpath e2e tests on multizone cluster.
```
k8s-github-robot pushed a commit that referenced this pull request Mar 17, 2018
Merge pull request #61238 from verult/automated-cherry-pick-of-#61111…
8c7c1c8 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #61111: Fix subpath e2e tests on multizone cluster.

Cherry pick of #61111 on release-1.7.

#61111: Fix subpath e2e tests on multizone cluster.

``` release-note
Fixes GCE PD volumes in subpath e2e tests on multizone cluster.
```
k8s-github-robot pushed a commit that referenced this pull request Mar 27, 2018
Merge pull request #61237 from verult/automated-cherry-pick-of-#61111…
edef43c 
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #61111: Fix subpath e2e tests on multizone cluster.

Cherry pick of #61111 on release-1.8.

#61111: Fix subpath e2e tests on multizone cluster.

``` release-note
Fixes GCE PD volumes in subpath e2e tests on multizone cluster.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jeffvance jeffvance Awaiting requested review from jeffvance

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

Subpath tests don't work in multizone GCE
5 participants
@jsafrane @k8s-ci-robot @liggitt @k8s-github-robot @msau42